Skip to content

test: Refactor manage access e2e tests#3645

Merged
sea-snake merged 10 commits intomainfrom
sea-snake/refactor-manage-e2e
Mar 4, 2026
Merged

test: Refactor manage access e2e tests#3645
sea-snake merged 10 commits intomainfrom
sea-snake/refactor-manage-e2e

Conversation

@sea-snake
Copy link
Contributor

Refactor manage access e2e tests, based on a prior PR, this PR implements a fixture for the manage access methods page and rewrites and consolidates the tests accordingly.

Changes

  • Wrap all e2e tests in routes folder next to fixtures.
  • Rename dashboard to manage to match route naming
  • Implement manageAccessPage fixture based on prior PR.
  • Update identity fixture to add method to replace dummy auth index of an identity.
  • Rewrites and consolidates passkey e2e tests into a single access tests file.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the Playwright E2E suite to better match the app’s route structure (moving tests under routes/ and introducing page fixtures), and consolidates the manage-access/passkey flows into a single access.spec.ts backed by a manageAccessPage fixture.

Changes:

  • Adjust test imports to use the shared ../fixtures + ../utils from route-based test locations.
  • Add a new manageAccessPage fixture and merge it into the shared fixtures bundle.
  • Replace legacy dashboard/*passkey*.spec.ts tests with consolidated route-based manage access tests.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/frontend/tests/e2e-playwright/routes/recovery.spec.ts Update imports for new route-based test layout.
src/frontend/tests/e2e-playwright/routes/manage/recovery.spec.ts Update imports for new route-based test layout.
src/frontend/tests/e2e-playwright/routes/manage/migration.spec.ts Update utils import path.
src/frontend/tests/e2e-playwright/routes/manage/index.spec.ts Update utils import path.
src/frontend/tests/e2e-playwright/routes/manage/access.spec.ts New consolidated manage access/passkey E2E coverage.
src/frontend/tests/e2e-playwright/routes/index.spec.ts Update imports for new route-based test layout.
src/frontend/tests/e2e-playwright/routes/authorize/* Update utils/fixtures import paths for new folder depth.
src/frontend/tests/e2e-playwright/fixtures/manageAccessPage.ts New page-object fixture for manage access methods flows.
src/frontend/tests/e2e-playwright/fixtures/index.ts Merge manageAccessPage fixture into shared test fixture.
src/frontend/tests/e2e-playwright/fixtures/identity.ts Add helper to swap dummy auth index for an identity in tests.
src/frontend/tests/e2e-playwright/dashboard/addPasskeys.spec.ts Remove legacy dashboard-based tests.
src/frontend/tests/e2e-playwright/dashboard/removePasskey.spec.ts Remove legacy dashboard-based tests.
src/frontend/tests/e2e-playwright/dashboard/renamePasskeys.spec.ts Remove legacy dashboard-based tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@aterga aterga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

@sea-snake sea-snake requested a review from aterga March 4, 2026 15:00
@sea-snake sea-snake added this pull request to the merge queue Mar 4, 2026
Merged via the queue into main with commit e5ee756 Mar 4, 2026
63 checks passed
@sea-snake sea-snake deleted the sea-snake/refactor-manage-e2e branch March 4, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants