test: Refactor manage access e2e tests#3645
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the Playwright E2E suite to better match the app’s route structure (moving tests under routes/ and introducing page fixtures), and consolidates the manage-access/passkey flows into a single access.spec.ts backed by a manageAccessPage fixture.
Changes:
- Adjust test imports to use the shared
../fixtures+../utilsfrom route-based test locations. - Add a new
manageAccessPagefixture and merge it into the shared fixtures bundle. - Replace legacy
dashboard/*passkey*.spec.tstests with consolidated route-based manage access tests.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/frontend/tests/e2e-playwright/routes/recovery.spec.ts | Update imports for new route-based test layout. |
| src/frontend/tests/e2e-playwright/routes/manage/recovery.spec.ts | Update imports for new route-based test layout. |
| src/frontend/tests/e2e-playwright/routes/manage/migration.spec.ts | Update utils import path. |
| src/frontend/tests/e2e-playwright/routes/manage/index.spec.ts | Update utils import path. |
| src/frontend/tests/e2e-playwright/routes/manage/access.spec.ts | New consolidated manage access/passkey E2E coverage. |
| src/frontend/tests/e2e-playwright/routes/index.spec.ts | Update imports for new route-based test layout. |
| src/frontend/tests/e2e-playwright/routes/authorize/* | Update utils/fixtures import paths for new folder depth. |
| src/frontend/tests/e2e-playwright/fixtures/manageAccessPage.ts | New page-object fixture for manage access methods flows. |
| src/frontend/tests/e2e-playwright/fixtures/index.ts | Merge manageAccessPage fixture into shared test fixture. |
| src/frontend/tests/e2e-playwright/fixtures/identity.ts | Add helper to swap dummy auth index for an identity in tests. |
| src/frontend/tests/e2e-playwright/dashboard/addPasskeys.spec.ts | Remove legacy dashboard-based tests. |
| src/frontend/tests/e2e-playwright/dashboard/removePasskey.spec.ts | Remove legacy dashboard-based tests. |
| src/frontend/tests/e2e-playwright/dashboard/renamePasskeys.spec.ts | Remove legacy dashboard-based tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aterga
reviewed
Mar 4, 2026
aterga
reviewed
Mar 4, 2026
aterga
reviewed
Mar 4, 2026
aterga
reviewed
Mar 4, 2026
aterga
reviewed
Mar 4, 2026
aterga
reviewed
Mar 4, 2026
aterga
reviewed
Mar 4, 2026
aterga
reviewed
Mar 4, 2026
aterga
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor manage access e2e tests, based on a prior PR, this PR implements a fixture for the manage access methods page and rewrites and consolidates the tests accordingly.
Changes
routesfolder next tofixtures.dashboardtomanageto match route namingmanageAccessPagefixture based on prior PR.accesstests file.