Change reverse scan param format#216
Conversation
|
Thanks! Any test file that you could share? |
|
Yes, I just got the permission from the lab scientist to share the file. I can add a test in the next few days. |
|
Well, I have no way of checking it and since the change doesn't seem to break any existing tests, I guess it was mislabeled. Thanks for the PR! Is there any attribution necessary for the test file? |
|
The testfile is shared by Niklas Hausmann (HZB). Of course it would be nice if we could name him. Otherwise he's also willing to share it like this. |
|
Do you have some procedure how you name the providers of testfiles? Is there a place inside the file or in the code where I should put it? |
|
Sorry for the tardy reply. Please add a line into the version notes: https://github.com/dgbowl/yadg/blob/main/docs/source/version.6_2.rst |
* Change reverse scan param format * Add test for issue 217 * Change column ID for CV to Rcmp * Add thank you note for Niklas CV files (#216)
* Change reverse scan param format * Add test for issue 217 * Change column ID for CV to Rcmp * Add thank you note for Niklas CV files (#216)
2 participants
This PR corrects the reading of
Reverse Scan,Ef (V), andEf (V) vs.for CV files with eclab version 11.5