fix: use / for app module delimiter#1428
Merged
KaiVandivier merged 4 commits intomasterfrom Apr 8, 2025
Merged
Conversation
Contributor
|
🚀 Deployed on https://pr-1428--dhis2-settings.netlify.app |
tomzemp
approved these changes
Mar 26, 2025
KaiVandivier
requested changes
Mar 26, 2025
src/App.jsx
Outdated
| module.defaultAction.substr(0, 3) === '../' | ||
| ? module.name | ||
| : `app:${module.name}`, | ||
| : `apps${appsModuleDelimiter}${module.name}`, |
Contributor
There was a problem hiding this comment.
Right now this is apps: (plural) or apps/ -- shouldn't it be app: (singular) for the < 42?
Maybe this approach:
const appsModulePrefix= apiVersion >= 42 ? 'apps/' : 'app:'
const startModules = (data.apps.modules || []).map((module) => ({
id:
module.defaultAction.substr(0, 3) === '../'
? module.name
: appsModulePrefix + module.name,
Member
There was a problem hiding this comment.
thanks for the catch! for whatever reason, it worked with apps: in v41 when I tested, but I confirmed with Morten that it should yes be:
app:for v41 and priorapps/for v42 and later
KaiVandivier
approved these changes
Apr 8, 2025
dhis2-bot
added a commit
that referenced
this pull request
Apr 8, 2025
## [100.7.3](v100.7.2...v100.7.3) (2025-04-08) ### Bug Fixes * use correct app module prefix for right version ([#1428](#1428)) ([2e4ed77](2e4ed77))
Contributor
|
🎉 This PR is included in version 100.7.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.