Skip to content

fix: use / for app module delimiter #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KaiVandivier merged 4 commits into from
Apr 8, 2025
Merged

fix: use / for app module delimiter #1428

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42a6fc0
fix: use / for app module delimiter
netroms Mar 25, 2025
f648ec8
fix: use / for app module delimiter
netroms Mar 25, 2025
f973205
fix: feature toggle
tomzemp Mar 26, 2025
e2c2dc3
fix: use correct app or apps
tomzemp Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,11 +134,12 @@ const AppWrapper = () => {
userSettingsNoFallback,
} = data

const appsModuleDelimiter = apiVersion >= 42 ? '/' : ':'
const startModules = (data.apps.modules || []).map((module) => ({
id:
module.defaultAction.substr(0, 3) === '../'
? module.name
: `app:${module.name}`,
: `apps${appsModuleDelimiter}${module.name}`,
Copy link
Contributor

@KaiVandivier KaiVandivier Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now this is apps: (plural) or apps/ -- shouldn't it be app: (singular) for the < 42?

Maybe this approach:

    const appsModulePrefix= apiVersion >= 42 ? 'apps/' : 'app:'
    const startModules = (data.apps.modules || []).map((module) => ({
        id:
            module.defaultAction.substr(0, 3) === '../'
                ? module.name
                : appsModulePrefix + module.name,

Copy link
Member

@tomzemp tomzemp Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the catch! for whatever reason, it worked with apps: in v41 when I tested, but I confirmed with Morten that it should yes be:

  • app: for v41 and prior
  • apps/ for v42 and later

displayName: module.displayName || module.name,
}))

Expand Down
Loading