Skip to content

Conversation

@hattne
Copy link
Collaborator

@hattne hattne commented Jul 5, 2025

Passes tests with or without the fix.

@hattne hattne requested a review from phyy-nx July 7, 2025 01:40
@hattne hattne marked this pull request as ready for review July 7, 2025 01:40
@phyy-nx
Copy link
Member

phyy-nx commented Jul 12, 2025

The change to examples/cbf2adscimg_sub.c just makes the semicolon more obvious, right? Code does the same thing in both cases?

@hattne
Copy link
Collaborator Author

hattne commented Jul 13, 2025

The change to examples/cbf2adscimg_sub.c just makes the semicolon more obvious, right? Code does the same thing in both cases?

Yes, that's right. However, some compilers warn about these lines of code, and I agree that they are a tad misleading.

In fact, the only case where actual behavior is changed is in cbf_testxfelread.c.

@phyy-nx
Copy link
Member

phyy-nx commented Jul 13, 2025

Oh snap, yep that's a change

@hattne
Copy link
Collaborator Author

hattne commented Jul 13, 2025

Oh snap, yep that's a change

Yes, and I assume the code as patched is what was intended (the if without the patch does nothing). Oddly, the tests pass with or without the patch; maybe the test image (idx-s00-20131106040304531.cbf) does not have any undefined or overloaded pixel values?

@yayahjb yayahjb self-assigned this Sep 4, 2025
Copy link
Collaborator

@yayahjb yayahjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable change

@yayahjb yayahjb merged commit 96c7986 into dials:main Sep 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants