Skip to content

Fix potential if-semicolon issue #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yayahjb merged 3 commits into from
Sep 4, 2025
Merged

Fix potential if-semicolon issue #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c93bfd9
Looks like an if-semicolon bug
hattne Jul 5, 2025
7782db6
Clarify similar for-semicolon issues
hattne Jul 5, 2025
adf61af
Misleading indentation
hattne Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions examples/cbf2adscimg_sub.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ static void puthd (char* field, char* value, char* header)
/*
* find the } marking the end of the information in the header
*/
for ( hp=header; *hp != '}'; hp++);
for ( hp=header; *hp != '}'; hp++)
;

/*
* Write the field name starting at the position of the }
Expand Down Expand Up @@ -214,7 +215,8 @@ static void padhd (char* header, int size)
/*
* find the } marking the end of the header
*/
for ( hp=header; *hp != '}'; hp++);
for ( hp=header; *hp != '}'; hp++)
;
hp++;

/*
Expand Down
5 changes: 3 additions & 2 deletions examples/cbf_testxfelread.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,8 +1030,9 @@ extern "C" {
for (ii=0; ii < XFEL_DIAMETER; ii++) {
for (jj=0; jj < XFEL_DIAMETER; jj++) {
if (outarray[ii][jj] != XFEL_UNDEFINED
&& outarray[ii][jj] != XFEL_OVERLOAD);
intoutarray[ii][jj] = (int)(outarray[ii][jj]+0.5);
&& outarray[ii][jj] != XFEL_OVERLOAD) {
intoutarray[ii][jj] = (int)(outarray[ii][jj]+0.5);
}
}
}

Expand Down
6 changes: 3 additions & 3 deletions src/cbf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2500,12 +2500,12 @@ int cbf_select_saveframe (cbf_handle handle, unsigned int saveframe)
return CBF_ARGUMENT;


/* Find the data block node */
/* Find the data block node */

cbf_failnez (cbf_find_parent (&node, handle->node, CBF_DATABLOCK))
cbf_failnez (cbf_find_parent (&node, handle->node, CBF_DATABLOCK))


/* Select the save frame */
/* Select the save frame */

isf = 0;

Expand Down