test: fix flaky rotation_between_is_identity#1542
Merged
geo-ant merged 1 commit intodimforge:mainfrom Sep 29, 2025
Merged
Conversation
geo-ant
reviewed
Sep 28, 2025
geo-ant
requested changes
Sep 28, 2025
Collaborator
geo-ant
left a comment
There was a problem hiding this comment.
overall LGTM, one small remark in the code
This fixes following test failure: ---- geometry::rotation::proptest_tests::rotation_between_is_identity stdout ---- proptest: Saving this and future failures in /home/im/projects/patches/nalgebra/proptest-regressions/geometry/rotation.txt proptest: If this test was run on a CI system, you may wish to add the following line to your copy of the file. (You may need to create it.) cc 3f8e4df3b22ad80e431c610aec6ed6368da0198877fc96a07dd00978cfce619a thread 'geometry::rotation::proptest_tests::rotation_between_is_identity' panicked at tests/geometry/rotation.rs:99:5: Test failed: assertion failed: `(left == right)` left: `[[1.0, 8.23149217580028e-11, 1.6462984785248345e-10], [-8.231492522718508e-11, 0.9999999999999998, 2.1072620414097273e-8], [-1.6462984611789232e-10, -2.1072620414110825e-8, 0.9999999999999998]]`, right: `[[1.0, 0.0, 0.0], [0.0, 1.0, 0.0], [0.0, 0.0, 1.0]]` at tests/geometry/rotation.rs:209. minimal failing input: v2 = [ [ 0.0, 0.0, ], ], v3 = [ [ 0.909512349774636, 59.888745019601366, -71.4865423250859, ], ] successes: 22 local rejects: 0 global rejects: 0
d8fbb45 to
a2d4ac3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes following test failure: