Skip to content

Fix #310: Matrix index out of bounds. #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebcrozet merged 6 commits into from
Jul 11, 2025
Merged

Fix #310: Matrix index out of bounds. #319

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
921832b
Fix #310: Matrix index out of bounds.
Johannes0021 Mar 4, 2025
c168599
Fix #310: Matrix index out of bounds. + Clippy
Johannes0021 Mar 19, 2025
f5995b1
Merge branch 'master' into matrix_index_out_of_bounds_310
ThierryBerger Jun 25, 2025
8940a19
add test + changelog
ThierryBerger Jun 25, 2025
8ebb371
simpler tests api used
ThierryBerger Jul 2, 2025
b65f1ca
fix: make clip_aabb_line return a result if the line’s starting point…
sebcrozet Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/query/clip/clip_aabb_line.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,11 @@ pub fn clip_aabb_line(
let near = if near_diag {
(tmin, -dir.normalize(), near_side)
} else {
// If near_side is 0, the index calculation would be invalid (-1).
if near_side == 0 {
return None;
}

let mut normal = Vector::zeros();

if near_side < 0 {
Expand All @@ -147,6 +152,11 @@ pub fn clip_aabb_line(
let far = if far_diag {
(tmax, -dir.normalize(), far_side)
} else {
// If far_side is 0, the index calculation would be invalid (-1).
if far_side == 0 {
return None;
}

let mut normal = Vector::zeros();

if far_side < 0 {
Expand Down