Fix bvh crashing when removing and adding a lot of collider in the same frame.#366
Closed
ThierryBerger wants to merge 1 commit intodimforge:masterfrom
Closed
Fix bvh crashing when removing and adding a lot of collider in the same frame.#366ThierryBerger wants to merge 1 commit intodimforge:masterfrom
ThierryBerger wants to merge 1 commit intodimforge:masterfrom
Conversation
Member
|
Thank you! This PR addresses the symptom but not the root cause of the issue. The root bug is fixed in #367 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered a crash while updating bevy_rapier, and tracked it to this fix.
It would be worth verifying the rest of the logic, and add more tests.
Reproduce on dimforge/bevy_rapier@af92a92: run
cargo run --example testbed2-> change example toropejoint2(but any other demo change will trigger the crash)Backtrace