Skip to content

Make MeshConverter enum derive Copy #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThierryBerger merged 2 commits into from
Apr 11, 2025
Merged

Make MeshConverter enum derive Copy #821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dab999e
Make `MeshConverter` enum derive `Copy`
waywardmonkeys Apr 10, 2025
076e9a9
update changelog
ThierryBerger Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## Unreleased

### Added

- `MeshConverter` now implements `Copy`.

## v0.24.0 (10 April 2025)

### Added
Expand Down
3 changes: 1 addition & 2 deletions src/geometry/mesh_converter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ pub enum MeshConverterError {
}

/// Determines how meshes (generally when loaded from a file) are converted into Rapier colliders.
// TODO: implement Copy once we add a Copy implementation for VHACDParameters.
#[derive(Clone, Debug, PartialEq, Default)]
#[derive(Clone, Copy, Debug, PartialEq, Default)]
pub enum MeshConverter {
/// The mesh is loaded as-is without any particular processing.
#[default]
Expand Down