Open
Conversation
npostavs
reviewed
Mar 16, 2019
| :description "Awesome shell extension base on eshell with wonderful features!" | ||
| :pkgname "manateelazycat/aweshell" | ||
| :post-init | ||
| (require 'aweshell)) |
Collaborator
There was a problem hiding this comment.
Is this require really needed?
Contributor
Author
There was a problem hiding this comment.
The author doesn't use autoload in the code. I have no idea which function should I add autoload in the recipe, so I use require to load it. Any suggestion of fixing this?
Collaborator
There was a problem hiding this comment.
I have no idea which function should I add
autoloadin the recipe,
The interactive commands are usually a good place to start. May ask the package author too?
Aweshell will be required once the user initializes the eshell-mode
Contributor
Author
|
This should work. When the user initializes the |
npostavs
reviewed
Feb 14, 2020
| :description "Awesome shell extension base on eshell with wonderful features!" | ||
| :pkgname "manateelazycat/aweshell" | ||
| :prepare | ||
| (autoload 'eshell "aweshell" nil t)) |
Collaborator
There was a problem hiding this comment.
This looks strange and likely to break eshell to me. Maybe use (eval-after-load 'eshell '(require 'aweshell)) instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aweshell is a powerful extension to the original eshell.