Skip to content

add a recipe: aweshell #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yfwu wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add a recipe: aweshell #2691

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce3d302
aweshell
yfwu Mar 10, 2019
7736bcf
add require
yfwu Mar 10, 2019
41cab5b
Update aweshell.rcp
yfwu Dec 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions recipes/aweshell.rcp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
(:name aweshell
:type github
:description "Awesome shell extension base on eshell with wonderful features!"
:pkgname "manateelazycat/aweshell"
:post-init
(require 'aweshell))
Copy link
Copy Markdown
Collaborator

@npostavs npostavs Mar 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this require really needed?

Copy link
Copy Markdown
Contributor Author

@yfwu yfwu Mar 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The author doesn't use autoload in the code. I have no idea which function should I add autoload in the recipe, so I use require to load it. Any suggestion of fixing this?

Copy link
Copy Markdown
Collaborator

@npostavs npostavs Mar 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea which function should I add autoload in the recipe,

The interactive commands are usually a good place to start. May ask the package author too?