Skip to content

Conversation

@neheb
Copy link
Contributor

@neheb neheb commented Oct 15, 2025

No description provided.

@neheb
Copy link
Contributor Author

neheb commented Oct 15, 2025

--- a/libffmpegthumbnailer/moviedecoder.cpp
+++ b/libffmpegthumbnailer/moviedecoder.cpp
@@ -318,7 +318,7 @@ std::string MovieDecoder::createScaleString(const std::string& sizeString, bool
     return scale.str();
 }

-void MovieDecoder::initializeFilterGraph(const AVRational& timeBase, const std::string& size, bool maintainAspectRatio)
+void MovieDecoder::initializeFilterGraph(AVRational timeBase, const std::string& size, bool maintainAspectRatio)
 {
     m_pFilterGraph = avfilter_graph_alloc();
     assert(m_pFilterGraph);
diff --git a/libffmpegthumbnailer/moviedecoder.h b/libffmpegthumbnailer/moviedecoder.h
index 22113d4..26ab39a 100644
--- a/libffmpegthumbnailer/moviedecoder.h
+++ b/libffmpegthumbnailer/moviedecoder.h
@@ -64,7 +64,7 @@ private:
     int32_t findPreferredVideoStream(bool preferEmbeddedMetadata);

     void initializeVideo(bool preferEmbeddedMetadata);
-    void initializeFilterGraph(const AVRational& timeBase, const std::string& size, bool maintainAspectRatio);
+    void initializeFilterGraph(AVRational timeBase, const std::string& size, bool maintainAspectRatio);^M

     bool decodeVideoPacket();
     bool getVideoPacket();

doesn't work. This should probably be a pointer.

@neheb
Copy link
Contributor Author

neheb commented Oct 15, 2025

oh nvm.

/home/runner/work/ffmpegthumbnailer/ffmpegthumbnailer/test/videothumbnailerctest.cpp:131: FAILED:
  CHECK( 0 == strcmp("Could not open input file: invalidfile.mpg", msg) )
with expansion:
  0 == -35

is not related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant