Update outdated or inaccurate interfaces in the app sdk #7403
Conversation
brad-discord
left a comment
brad-discord
left a comment
There was a problem hiding this comment.
I'm not too familiar with this space, but I do have some questions.
| | application? | [MessageApplication](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/messageapplication) \| null | | ||
| | message_reference? | [MessageReference](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/messagereference) \| null | | ||
| | flags? | number | | ||
| | stickers? | Sticker[] \| null | |
There was a problem hiding this comment.
Not part of your change, but should Sticker be a link to another part of the docs?
There was a problem hiding this comment.
There was a problem hiding this comment.
if this is an api message object, stickers is deprecated and only present on old messages, and new messages use the sticker_items field
There was a problem hiding this comment.
it is yeah, i think the maintainers of the SDK forgot to add sticker_items since it is not present
| | mention_channels? | [ChannelMention](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/channelmention)[] | | ||
| | attachments | [Attachment](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/attachment)[] | | ||
| | embeds | [Embed](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/embed)[] | | ||
| | reactions? | [Reaction](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/reaction)[] | | ||
| | nonce? | string | | ||
| | pinned | boolean | | ||
| | webhook_id? | string | | ||
| | type | number | | ||
| | activity? | [MessageActivity](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/messageactivity) | | ||
| | application? | [MessageApplication](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/messageapplication) | | ||
| | message_reference? | [MessageReference](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/messagereference) | | ||
| | flags? | number | | ||
| | stickers? | Sticker[] | | ||
| | referenced_message? | [Message](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/message) | | ||
| | Property | Type | | ||
| |---------------------|-----------------------------------------------------------------------------------------| | ||
| | id | string | | ||
| | channel_id | string | | ||
| | guild_id? | string \| null | | ||
| | author? | [User](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/user) \| null | | ||
| | member? | [GuildMember](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/guildmember) \| null | | ||
| | content | string | | ||
| | timestamp | string | | ||
| | edited_timestamp? | string \| null | | ||
| | tts | boolean | | ||
| | mention_everyone | boolean | | ||
| | mentions | [User](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/user)[] | | ||
| | mention_roles | string[] | | ||
| | mention_channels | [ChannelMention](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/channelmention)[] | |
There was a problem hiding this comment.
That's interesting - what happened to make mention_channels no longer optional in this context? It looks like it's optional on the Message resource
There was a problem hiding this comment.
either the sdk or Message resource are wrong, I directly checked the sdk's code
|
Please |
brad-discord
left a comment
brad-discord
left a comment
There was a problem hiding this comment.
Awesome, thank you for the contribution!
* Update Embedded App SDK interfaces * Update Embedded App SDK enums * resolve comment * Format tables via fix:tables
4 participants
No description provided.