fix: Message forwards do not require other fields #7830
Merged
+18
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
reviewed
Sep 12, 2025
Lulalaby
reviewed
Sep 13, 2025
docs/resources/message.mdx
Outdated
|
|
||
| :::info | ||
| When creating a message, apps must provide a value for **at least one of** `content`, `embeds`, `sticker_ids`, `components`, `files[n]`, or `poll`. | ||
| When creating a message, apps must provide a value for **at least one of** `content`, `embeds`, `sticker_ids`, `components`, `files[n]`, `poll`, or `message_reference` (only when reference type is [`FORWARD`](/docs/resources/message#message-reference-types)). |
Contributor
There was a problem hiding this comment.
honestly that still sounds off. i was more a fan of marks suggestion
Suggested change
| When creating a message, apps must provide a value for **at least one of** `content`, `embeds`, `sticker_ids`, `components`, `files[n]`, `poll`, or `message_reference` (only when reference type is [`FORWARD`](/docs/resources/message#message-reference-types)). | |
| When creating a message, apps must provide a value for **at least one of** `content`, `embeds`, `sticker_ids`, `components`, `files[n]`, [forwarding](/docs/resources/message#message-reference-types) `message_reference` or `poll`. |
maybe we could meet in the middle here?
Contributor
There was a problem hiding this comment.
Also don't forget about
We should also update line 644, since it duplicates this one
Contributor
Author
There was a problem hiding this comment.
isn't specifying the type clearer here? not sure tbh
Contributor
There was a problem hiding this comment.
it's the wording for me here. it doesn't add up with the rest of the sentence
Contributor
There was a problem hiding this comment.
i wouldn't remove the info box 😅
Contributor
Author
There was a problem hiding this comment.
it doesn't make sense to keep both of them
Contributor
There was a problem hiding this comment.
I like that a lot. Nicely done.
markmandel
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.