Skip to content

fix: Message forwards do not require other fields #7830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 15, 2025
Merged

fix: Message forwards do not require other fields #7830

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0dcf8a
Message forwards do not require other fields
ManHatos Sep 10, 2025
bd010a6
clarify wording
ManHatos Sep 13, 2025
828314d
Update message.mdx
ManHatos Sep 13, 2025
093e442
remove duplicate note, reword
ManHatos Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/resources/message.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,7 @@ Files must be attached using a `multipart/form-data` body as described in [Uploa
###### JSON/Form Params

:::info
When creating a message, apps must provide a value for **at least one of** `content`, `embeds`, `sticker_ids`, `components`, `files[n]`, or `poll`.
When creating a message, apps must provide a value for **at least one of** `content`, `embeds`, `sticker_ids`, `components`, `files[n]`, `poll`, or `message_reference` (only when reference type is [`FORWARD`](/docs/resources/message#message-reference-types)).
Copy link
Contributor

@Lulalaby Lulalaby Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly that still sounds off. i was more a fan of marks suggestion

Suggested change
When creating a message, apps must provide a value for **at least one of** `content`, `embeds`, `sticker_ids`, `components`, `files[n]`, `poll`, or `message_reference` (only when reference type is [`FORWARD`](/docs/resources/message#message-reference-types)).
When creating a message, apps must provide a value for **at least one of** `content`, `embeds`, `sticker_ids`, `components`, `files[n]`, [forwarding](/docs/resources/message#message-reference-types) `message_reference` or `poll`.

maybe we could meet in the middle here?

Copy link
Contributor

@Lulalaby Lulalaby Sep 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also don't forget about

We should also update line 644, since it duplicates this one

Copy link
Contributor Author

@ManHatos ManHatos Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't specifying the type clearer here? not sure tbh

Copy link
Contributor

@Lulalaby Lulalaby Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the wording for me here. it doesn't add up with the rest of the sentence

Copy link
Contributor Author

@ManHatos ManHatos Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, lmk

Copy link
Contributor

@Lulalaby Lulalaby Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wouldn't remove the info box 😅

Copy link
Contributor Author

@ManHatos ManHatos Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't make sense to keep both of them

Copy link
Contributor

@Lulalaby Lulalaby Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm then

Copy link
Contributor

@markmandel markmandel Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that a lot. Nicely done.

:::

| Field | Type | Description |
Expand Down