Skip to content

types(core): use result types instead of direct types #11140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

types(core): use result types instead of direct types #11140

wants to merge 3 commits into from
+35 −6

Conversation

vladfrangu
Copy link
Member

@vladfrangu vladfrangu commented Oct 5, 2025 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

Just fixes some type references. WIll PR to DTypes to fix the thread return type being a generic channel instead of a specific type

Needs

Status and versioning classification:

@vladfrangu vladfrangu requested a review from a team as a code owner October 5, 2025 12:17
@vercel Vercel
Copy link

vercel bot commented Oct 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Oct 8, 2025 1:15pm
discord-js-guide Ignored Ignored Preview Oct 8, 2025 1:15pm

@Jiralite Jiralite marked this pull request as draft October 5, 2025 12:20
@Jiralite
Copy link
Member

Jiralite commented Oct 5, 2025

Drafting until the discord-api-types release.

Jiralite
Jiralite previously requested changes Oct 5, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js Oct 5, 2025
@Jiralite Jiralite modified the milestones: core 2.3.0, core 3.0.0 Oct 5, 2025
@Jiralite Jiralite dismissed their stale review October 5, 2025 12:33

Resolved.

@Jiralite Jiralite self-requested a review October 5, 2025 12:33
@codecov Codecov
Copy link

codecov bot commented Oct 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 44.20%. Comparing base (aac247c) to head (35d704f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/api/channel.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11140   +/-   ##
=======================================
  Coverage   44.20%   44.20%           
=======================================
  Files         313      313           
  Lines       18088    18088           
  Branches     1796     1796           
=======================================
  Hits         7996     7996           
  Misses      10080    10080           
  Partials       12       12
Flag Coverage Δ
core 0.91% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jiralite
Copy link
Member

Jiralite commented Oct 6, 2025

Please resolve conflicts!

@vladfrangu vladfrangu force-pushed the types/use-return-types-instead-of-direct-types branch from ed52cd1 to 66241cc Compare October 7, 2025 09:55
@vladfrangu vladfrangu marked this pull request as ready for review October 7, 2025 09:56
almeidx
almeidx reviewed Oct 7, 2025
View reviewed changes
Jiralite
Jiralite reviewed Oct 8, 2025
View reviewed changes
@vladfrangu
types(core): use result types instead of direct types
1fcc735 
fix: import pains

chore: apply suggestion from review

Co-authored-by: Almeida <[email protected]>

chore: fmt script

chore: requested change
@vladfrangu vladfrangu force-pushed the types/use-return-types-instead-of-direct-types branch from ca625d6 to 1fcc735 Compare October 8, 2025 09:03
Jiralite
Jiralite reviewed Oct 8, 2025
View reviewed changes
@vladfrangu
Copy link
Member Author 

The following routes are not implemented:
 - guildMemberVerification

@Jiralite
Copy link
Member

Jiralite commented Oct 8, 2025

That's an unstable/undocumented route so that's fine.

almeidx
almeidx reviewed Oct 8, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jiralite Jiralite Jiralite approved these changes

@almeidx almeidx almeidx approved these changes

@Qjuh Qjuh Qjuh approved these changes

@sdanialraza sdanialraza sdanialraza approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

At least 3 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

backport-candidate packages:core semver:patch

Projects

discord.js
Status: Review in Progress

Milestone

core 3.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@vladfrangu @Jiralite @almeidx @Qjuh @sdanialraza