types(core): use result types instead of direct types

packages/core/scripts/find-returns-not-return-type.mts

@@ -0,0 +1,28 @@
+import { glob, readFile } from 'node:fs/promises';
+
+const cwd = new URL('../src/api/', import.meta.url);
+const results: string[] = [];
+
+for await (const file of glob('**/*.ts', { cwd })) {
+	const content = await readFile(new URL(file, cwd), { encoding: 'utf-8' });
+
+	const matches = content.matchAll(/as Promise<(?<returnType>\w+)>/g);
+
+	for (const match of matches) {
+		const returnType = match.groups!.returnType!;
+
+		if (!returnType.startsWith('REST') || !returnType.includes('Result')) {
+			results.push(`in file core/src/api/${file}: ${returnType}`);
+		}
+	}
+}
+
+if (results.length > 0) {
+	console.warn('Found return types that are not REST return types:');
+
+	for (const result of results) {
+		console.warn(`  - ${result}`);
+	}
+} else {
+	console.log('No return types that are not REST return types found');
+}

packages/core/src/api/channel.ts

@@ -29,8 +29,6 @@ import {
 	type RESTPostAPIChannelMessageResult,
 	type RESTPostAPIChannelThreadsJSONBody,
 	type RESTPostAPIChannelThreadsResult,
-	type RESTPostAPIChannelWebhookJSONBody,
-	type RESTPostAPIChannelWebhookResult,
 	type RESTPostAPIGuildForumThreadsJSONBody,
 	type RESTPostAPISendSoundboardSoundResult,
 	type RESTPostAPISoundboardSendSoundJSONBody,
@@ -566,7 +564,7 @@ export class ChannelsAPI {
 			body,
 			reason,
 			signal,
-		}) as Promise<APIThreadChannel>;
+		}) as Promise<RESTPostAPIChannelThreadsResult>;
 	}
 
 	/**