FIX: Check post action creator result when flagging spam #1119
Conversation
Currently in core re-flagging something that is already flagged as spam is not supported, long term we may want to support this but in the meantime we should not be silencing/hiding if the PostActionCreator fails when flagging things as spam.
Drenmi
left a comment
Drenmi
left a comment
There was a problem hiding this comment.
LGTM! Some small nits. Can't answer the question you asked from Sam. 🚀
|
approving, this is already better than what we have, but an audit trail that we tried to flag and had no luck would be nice for future debugging. |
Co-authored-by: Ted Johansson <[email protected]>
martin-brennan
force-pushed
the
fix/check-pa-result-spam
branch
from
09e5fc4 to
39dcfab
Compare
|
nice I like this approach.. do we want error as text or JSON ? It probably does not matter that much but JSON does have some advantages given it is structured but the downside is that you can not easily limit length. |
martin-brennan
force-pushed
the
fix/check-pa-result-spam
branch
from
54e0fe5 to
f3b9362
Compare
|
@SamSaffron I think the text is fine. Core only gives an error message, and not a super useful one at that since it's user readable for example "Oops! You already performed this action. Can you try refreshing the page?". I think it will be enough of a clue for debugging, maybe in future |
|
no worries, I am good to have this merged 🤗 |
Currently in core re-flagging something that is already flagged as spam
is not supported, long term we may want to support this but in the meantime
we should not be silencing/hiding if the PostActionCreator fails
when flagging things as spam.