DEV: Send fancy_titles instead of titles for translation #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
force-pushed
the
translate-fancy-titles
branch
from
bdaa1dd to
1b38232
Compare
Contributor
Author
|
Unfortunately this cannot be done. Sending fancy_title for translation is good for the new feature, but would break the older feature where the titles are escaped. It would result in double escaping for the old featuer 
|
nattsw
added a commit
that referenced
this pull request
Feb 25, 2025
In the existing method of translation, we show the translated titles below the post cooked. When using the same already-translated titles for the experimental feature, it would result in the H1 rendering into large text in the topic title. We've been sending the `topic.title` in for translation, instead of the escaped `topic.fancy_title`, which works well for the existing method. I had considered changing our implementation to [send the fancy_titles (escaped) in for translation instead](#222), but that would result in our existing methods titles being double-escaped. To keep compatibility between existing and experimental, I will only escape it for the experimental feature. This commit does that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra context:
In the earlier implementation of topic title translations, we send the
topic.titleto the API, and titles are shown inline to the post as below:For the new experimental full-topic translations, we replace topic titles in the topic title container itself above the topic:
There is a problem here - sending a topic's title for translation for the experimental method is not safe since we directly replace the fancy_title attribute.
This results in translated titles that include the H1 tag.
Bug
Since we're sending the raw titles, this is what happens:
This PR sends our fancy_titles for translation instead.
Additional note: I am not creating a migration to update old values, as AI translations and full topic translations are still experimental.