FIX: Fancify titles when using experimental topic translation #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OsamaSayegh
approved these changes
Feb 25, 2025
| .topic | ||
| .translation_for(I18n.locale) | ||
| .presence | ||
| &.then { |t| Topic.fancy_title(t) } |
Member
There was a problem hiding this comment.
Oh TIL about #then, pretty neat! What happens if we get blank translation? Should we fallback to the original? Or is this handled on the client side?
Contributor
Author
There was a problem hiding this comment.
The modifier in core handles the case when this value is nil. (discourse/discourse@5f00ae2)
Contributor
Author
|
Thaaanks @OsamaSayegh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the existing method of translation, we show the translated titles below the post cooked:
When using the same already-translated titles for the experimental feature, it would result in the H1 rendering:
We've been sending the
topic.titlein for translation, instead of the escapedtopic.fancy_title, which works well for the existing method. I had considered changing our implementation to send the fancy_titles (escaped) in for translation instead, but that would result in our existing methods titles being double-escapedTo keep compatibility between existing and experimental, I will only escape it for the experimental feature. This PR does that.