Skip to content

FIX: Allow user to be deleted #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

FIX: Allow user to be deleted #236

merged 1 commit into from
Feb 28, 2025

Conversation

@nattsw
Copy link
Contributor

@nattsw nattsw commented Feb 28, 2025

There is a bug now where the post's user may not always be available, causing can_translate? to throw an error.

Message (2 copies reported)
NoMethodError (undefined method `bot?' for nil)
app/serializers/post_stream_serializer_mixin.rb:69:in `block in posts'

This PR fixes this issue.

jjaffeux
jjaffeux approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@jjaffeux jjaffeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the quick fix

@nattsw nattsw merged commit c7b3148 into main Feb 28, 2025
6 checks passed
@nattsw nattsw deleted the error-deleting-user branch February 28, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjaffeux jjaffeux jjaffeux approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nattsw @jjaffeux