Skip to content

FIX: Allow user to be deleted #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025
+7 −1
Merged

FIX: Allow user to be deleted #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/discourse_translator/guardian_extension.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def can_detect_language?(post)
end

def can_translate?(post)
return false if post.user.bot?
return false if post.user&.bot?
return false if !user_group_allow_translate?
return false if post.locale_matches?(I18n.locale)

Expand Down
6 changes: 6 additions & 0 deletions spec/lib/guardian_extension_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,5 +244,11 @@
end
end
end

it "does not error out when post user is deleted" do
post.update(user: nil)

expect { guardian.can_translate?(post) }.not_to raise_error
end
end
end
Loading