FIX: Incorrect lang mapping using non-symbols for LibreTranslate #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds test coverage for /translate endpoint
tyb-talks
approved these changes
Mar 4, 2025
| Excon | ||
| .expects(:get) | ||
| .with(SiteSetting.translator_libretranslate_endpoint + "/languages") | ||
| .returns(mock_response.new(200, [{ code: "de" }, { code: "en" }].to_json)) |
Contributor
There was a problem hiding this comment.
Rather than stubbing Excon could you use stub_request from core?
Contributor
Author
There was a problem hiding this comment.
We could, but this is not an issue at the moment so I'll just leave it for now.
Contributor
There was a problem hiding this comment.
It's worth a future refactor for consistency, looks like this plugin uses this method heaps instead of just using stub_request, maybe it predates stub_request
martin-brennan
approved these changes
Mar 4, 2025
Contributor
martin-brennan
left a comment
martin-brennan
left a comment
There was a problem hiding this comment.
Approving, just wondering about request mocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #206, we introduced a regression here when mapping supported locales.
This PR also adds a test for the LibreTranslate /translate API.