Skip to content

FIX: Incorrect lang mapping using non-symbols for LibreTranslate #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

FIX: Incorrect lang mapping using non-symbols for LibreTranslate #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/services/discourse_translator/libre_translate.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def self.translate!(translatable, target_locale_sym = I18n.locale)
translate_uri,
q: text_for_translation(translatable),
source: detected_lang,
target: SUPPORTED_LANG_MAPPING[target_locale],
target: SUPPORTED_LANG_MAPPING[target_locale_sym],
format: "html",
)
res["translatedText"]
Expand Down
38 changes: 37 additions & 1 deletion spec/services/libre_translate_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

RSpec.describe DiscourseTranslator::LibreTranslate do
let(:mock_response) { Struct.new(:status, :body) }
let(:api_key) { "12345" }

before { SiteSetting.translator_libretranslate_endpoint = "http://localhost:5000" }

describe ".access_token" do
describe "when set" do
Expand All @@ -17,7 +20,6 @@

describe ".translate_supported?" do
it "should equate source language to target" do
SiteSetting.translator_libretranslate_endpoint = "http://localhost:5000"
source = "en"
target = :fr

Expand All @@ -27,4 +29,38 @@
expect(described_class.translate_supported?(source, target)).to be true
end
end

describe ".translate" do
fab!(:post)

before do
SiteSetting.translator_libretranslate_api_key = api_key
Excon
.expects(:get)
.with(SiteSetting.translator_libretranslate_endpoint + "/languages")
.returns(mock_response.new(200, [{ code: "de" }, { code: "en" }].to_json))
Copy link
Contributor

@martin-brennan martin-brennan Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than stubbing Excon could you use stub_request from core?

https://github.com/discourse/discourse/blob/c815294c57976fd3d12f1114745e6a075d995db9/plugins/discourse-lazy-videos/spec/lib/lazy-videos/lazy_vimeo_spec.rb#L15-L18

Copy link
Contributor Author

@nattsw nattsw Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but this is not an issue at the moment so I'll just leave it for now.

Copy link
Contributor

@martin-brennan martin-brennan Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth a future refactor for consistency, looks like this plugin uses this method heaps instead of just using stub_request, maybe it predates stub_request

end

it "truncates text for translation to max_characters_per_translation setting" do
SiteSetting.max_characters_per_translation = 50
post.set_detected_locale("de")
body = { q: post.cooked, source: "de", target: "en", format: "html", api_key: api_key }

translated_text = "hur dur hur dur"
# https://publicapi.dev/libre-translate-api
Excon
.expects(:post)
.with(
SiteSetting.translator_libretranslate_endpoint + "/translate",
body: URI.encode_www_form(body),
headers: {
"Content-Type" => "application/x-www-form-urlencoded",
},
)
.returns(mock_response.new(200, %{ { "translatedText": "#{translated_text}"} }))
.once

expect(described_class.translate(post)).to eq(["de", translated_text])
end
end
end
Loading