fix pyright type errors for Django version compatibility#181
Merged
bckohan merged 1 commit intodjango-commons:mainfrom Mar 17, 2026
Merged
fix pyright type errors for Django version compatibility#181bckohan merged 1 commit intodjango-commons:mainfrom
bckohan merged 1 commit intodjango-commons:mainfrom
Conversation
- Use getattr() for ChoicesMeta to avoid static attr access on Django 5.0+ stubs - Suppress call-arg errors on CheckConstraint(check=...) backward-compat branches (Django < 5.1) - Suppress attr-defined error on connection.operators which is untyped in Django stubs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bckohan
approved these changes
Mar 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getattr(model_enums, "ChoicesMeta")instead of direct attribute access to avoid a pyright error on Django 5.0+ stubs whereChoicesMetano longer exists# type: ignore[call-arg]onCheckConstraint(check=...)backward-compatibility branches (Django < 5.1), since current Django stubs only expose thecondition=parameter# type: ignore[attr-defined]onconnection.operatorsaccess inquery.py, which is a real runtime attribute but absent from Django'sBaseDatabaseWrapperstubsTest plan
just check-types-pyrightand confirm0 errors, 0 warnings, 0 informations🤖 Generated with Claude Code