Skip to content

fix pyright type errors for Django version compatibility #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bckohan merged 1 commit into from
Mar 17, 2026
Merged

fix pyright type errors for Django version compatibility #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/django_enum/choices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
ChoicesType = (
model_enums.ChoicesType
if django_version[0:2] >= (5, 0)
else model_enums.ChoicesMeta
else getattr(model_enums, "ChoicesMeta") # removed in Django 5.0
)

DEFAULT_BOUNDARY = getattr(enum, "KEEP", None)
Expand Down
8 changes: 4 additions & 4 deletions src/django_enum/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,8 +787,8 @@ def contribute_to_class(
constraint |= Q(**{f"{self.name or name}__isnull": True})
cls._meta.constraints = [
*cls._meta.constraints,
CheckConstraint(
check=constraint,
CheckConstraint( # type: ignore[call-arg]
check=constraint, # type: ignore[call-arg]
name=self.constraint_name(cls, self.name or name, self.enum),
)
if django_version[0:2] < (5, 1)
Expand Down Expand Up @@ -1254,8 +1254,8 @@ def contribute_to_class(

cls._meta.constraints = [
*cls._meta.constraints,
CheckConstraint(
check=constraint,
CheckConstraint( # type: ignore[call-arg]
check=constraint, # type: ignore[call-arg]
name=self.constraint_name(cls, self.name or name, self.enum),
)
if django_version[0:2] < (5, 1)
Expand Down
2 changes: 1 addition & 1 deletion src/django_enum/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def process_lhs(self, compiler, connection, lhs=None):
return lhs_sql, lhs_params

def get_rhs_op(self, connection, rhs):
return connection.operators["exact"] % rhs
return connection.operators["exact"] % rhs # type: ignore[attr-defined]


# class ExtraBigFlagMixin:
Expand Down
Loading