HistoricOneToOneField #1394
Merged
HistoricOneToOneField #1394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…imple-history into historic-one-to-one
This was referenced Sep 16, 2024
Closed
kgeidel
approved these changes
Sep 18, 2024
|
Hi, is this going to be merged and if so when please |
Waiting for maintainers to review! |
tim-schilling
requested changes
Nov 19, 2024
|
We also need to credit @david-homelend in the commit. See https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors |
- Added suggested doc string to HistoricOneToOneField - Updated test doc strings
Co-authored-by: David Diamant <[email protected]>
|
Ok, I made the requested changes, let me know if I missed/messed something up! |
|
I had to update language_version: python3.11 in the .pre-commit-config.yaml because it was failing to find a python3.8 interpreter |
tim-schilling
approved these changes
Nov 20, 2024
|
I'll give it a go, no promises that it'll work because I don't have their email address. Sorry @quadracik if it doesn't work 🤞 |
|
It worked! 🎉 |
|
Thanks guys! I really appreciate it. |
acrawford13
pushed a commit
to guestready/django-simple-history
that referenced
this pull request
Aug 28, 2025
* Implemented HistoricOneToOneField with unit tests * Updated AUTHORS.rst * Added HistoricOneToOneFiled to querying_history.rst * removed call to field cache * - created HistoricDescriptorMixin to DRY out get_queryset method - Added suggested doc string to HistoricOneToOneField * Switch to lowest supported python version for pre-commit black --------- Co-authored-by: quadracik <[email protected]> Co-authored-by: David Diamant <[email protected]> Co-authored-by: Tim Schilling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for HistoricOneToOneField
Description
Implemented the solution proposed by @quadracik in issue #1031
Related Issue
This PR addresses issue #1031 and #1389
Motivation and Context
How Has This Been Tested?
Appropriate unit tests have been written and follow the ones written for HistoricForeignKey
Types of changes
Checklist:
pre-commit runcommand to format and lint.AUTHORS.rstCHANGES.rst