Compatibility fix for XGBoost 3.2#655
Conversation
|
@trivialfis Can you help review? This updates Treelite to support new layout for multi-target trees. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mainline #655 +/- ##
============================================
+ Coverage 84.35% 84.38% +0.03%
============================================
Files 75 75
Lines 6653 6653
Branches 543 543
============================================
+ Hits 5612 5614 +2
+ Misses 1041 1039 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trivialfis
left a comment
There was a problem hiding this comment.
The change looks good. What do you think of the new layout? Theoretically, the leaf weight can be omitted if reduced gradient is not used. But making an optional field makes the code and more complex.
|
@trivialfis Is reduced gradient only applicable for multi-target trees? If so, I like the layout. |
|
Yes, vector leaf only |
Update Treelite to 4.7.0 to incorporate the following improvements: * dmlc/treelite#655 * dmlc/treelite#651 Authors: - Philip Hyunsu Cho (https://github.com/hcho3) - Jim Crist-Harif (https://github.com/jcrist) Approvers: - Jim Crist-Harif (https://github.com/jcrist) - James Lamb (https://github.com/jameslamb) - Bradley Dice (https://github.com/bdice) URL: #7870
Since dmlc/xgboost#11814, XGBoost stores leaf weights as a separate field for multi-target trees.
Since multi-target trees are an experimental feature, we do not provide a compatibility layer for older versions of multi-target trees.