Skip to content

Daily fixes for the Nightly issue detector #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgageot merged 2 commits into from
Feb 19, 2026
Merged

Daily fixes for the Nightly issue detector #1787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e22db73
fix: close CPU profile file immediately on StartCPUProfile error
dgageot Feb 19, 2026
ce0795b
fix: handle error from Close() in isFirstRun
dgageot Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmd/root/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,9 @@ func isFirstRun() bool {
if err != nil {
return false // File already exists or other error, not first run
}
f.Close()
if err := f.Close(); err != nil {
slog.Warn("Failed to close first run marker file", "error", err)
}

return true
}
3 changes: 2 additions & 1 deletion cmd/root/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,12 @@ func (f *runExecFlags) runOrExec(ctx context.Context, out *cli.Printer, args []s
if err != nil {
return fmt.Errorf("failed to create CPU profile: %w", err)
}
defer pf.Close()
if err := pprof.StartCPUProfile(pf); err != nil {
pf.Close()
return fmt.Errorf("failed to start CPU profile: %w", err)
}
defer pprof.StopCPUProfile()
defer pf.Close()
slog.Info("CPU profiling enabled", "file", f.cpuProfile)
}

Expand Down