Daily fixes for the Nightly issue detector#1787
Merged
dgageot merged 2 commits intodocker:mainfrom Feb 19, 2026
Merged
Conversation
When pprof.StartCPUProfile fails, the file was left to be closed by a deferred call placed before the error check. This could shadow the original error and delay resource cleanup. Now the file is closed explicitly on error, and defer is placed after the success path. Fixes docker#1770 Fixes docker#1765 Assisted-By: cagent
The f.Close() call was ignoring the returned error. Now we log a warning if closing the first-run marker file fails. Fixes docker#1769 Assisted-By: cagent
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
✅ Approved - No issues found in the changed code.
This PR improves resource handling by:
cmd/root/root.go: Properly checking the error fromf.Close()and logging itcmd/root/run.go: Fixing the defer order for CPU profiling cleanup to ensurepf.Close()happens afterpprof.StopCPUProfile(), and properly closing the file on error before returning
The changes follow Go best practices for resource management and error handling. Nice cleanup work!
trungutt
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.