-
Notifications
You must be signed in to change notification settings - Fork 8.1k
DMR: add Docker CE base urls #22760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DMR: add Docker CE base urls #22760
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
content/manuals/ai/model-runner.md
Outdated
| enabled on the default port (12434). | ||
|
|
||
| {{< /tab >}} | ||
| {{< tab name="Docker CE">}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| {{< tab name="Docker CE">}} | |
| {{< tab name="Docker CE">}} |
Docker CE is the internal name for Docker Desktop 🤔 do we mean Docker Engine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker CE is the internal name for Docker Desktop
Not sure where you are getting this from, but that's not correct.
Docker CE is Docker Community Edition, our Docker distribution for Linux, consisting of Docker Engine (Moby), Docker CLI and BuildKit.
From our docs (which are fuzzy, agreed):
This section describes how to install Docker Engine on Linux, also known as Docker CE. Docker Engine
Since the docs are about adding Docker Model Runner to Docker CE (as a plugin), referring to Docker CE should be the right language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok yeh - not Docker Desktop, coffee hadn't hit the ol' brain matter yet.
We've never used Docker CE in docs or marketing to refer to Docker Engine on Linux (apart from this one sentence) so whilst technically correct, this is not how users know it and I fear this would add unnecessary confusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's indeed Docker Engine, as I also used in the top section... I also went through the confusion between CE/Engine last week 🫠
Co-authored-by: Kevin Wittek <[email protected]>
Co-authored-by: Kevin Wittek <[email protected]>
aevesdocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.