-
Notifications
You must be signed in to change notification settings - Fork 8.1k
DMR: add Docker CE base urls #22760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ArthurFlag
merged 4 commits into
docker:main
from
ArthurFlag:ENGDOCS-2692-update-api-info-for-ce
Jun 4, 2025
Merged
DMR: add Docker CE base urls #22760
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker CE is the internal name for Docker Desktop 🤔 do we mean Docker Engine?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure where you are getting this from, but that's not correct.
Docker CE is Docker Community Edition, our Docker distribution for Linux, consisting of Docker Engine (Moby), Docker CLI and BuildKit.
From our docs (which are fuzzy, agreed):
Since the docs are about adding Docker Model Runner to Docker CE (as a plugin), referring to Docker CE should be the right language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok yeh - not Docker Desktop, coffee hadn't hit the ol' brain matter yet.
We've never used Docker CE in docs or marketing to refer to Docker Engine on Linux (apart from this one sentence) so whilst technically correct, this is not how users know it and I fear this would add unnecessary confusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's indeed Docker Engine, as I also used in the top section... I also went through the confusion between CE/Engine last week 🫠