Skip to content

Conversation

@PeterStaar-IBM
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM commented Sep 23, 2025

Let's first merge this: #402

Signed-off-by: Peter Staar <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025

DCO Check Passed

Thanks @PeterStaar-IBM, all your commits are properly signed off. 🎉

@mergify
Copy link

mergify bot commented Sep 23, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Require two reviewer for test updates

This rule is failing.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

Signed-off-by: Peter Staar <[email protected]>
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 86.51685% with 48 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
docling_core/transforms/serializer/latex.py 90.53% 32 Missing ⚠️
docling_core/types/doc/document.py 11.11% 16 Missing ⚠️

📢 Thoughts on this report? Let us know!

@PeterStaar-IBM PeterStaar-IBM marked this pull request as ready for review October 15, 2025 04:31
@dosubot
Copy link

dosubot bot commented Oct 15, 2025

Related Documentation

Checked 3 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

Comment on lines +78 to +81
page_break_command: Optional[str] = None

# Escape LaTeX special characters in text
escape_latex: bool = True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to have some test coverage for all introduced params (I think e.g. these two are not covered).

* working on adding complex table support

Signed-off-by: Peter Staar <[email protected]>

* refactored the code

Signed-off-by: Peter Staar <[email protected]>

* updated the latex gt

Signed-off-by: Peter Staar <[email protected]>

---------

Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM PeterStaar-IBM force-pushed the dev/add-latex-serializer branch from d533e71 to 1bed3f6 Compare October 15, 2025 15:47
Signed-off-by: Peter Staar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants