Skip to content

Conversation

@vagenas
Copy link
Collaborator

@vagenas vagenas commented Nov 7, 2025

Suggests deprecating use_legacy_mode param & deriving whether to use "legacy" annotations (i.e. .annotations) as defined in _should_use_legacy_annotations() (which also takes care of preventing unnecessary warnings).

@vagenas vagenas requested a review from ceberam November 7, 2025 15:35
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

DCO Check Passed

Thanks @vagenas, all your commits are properly signed off. 🎉

@mergify
Copy link

mergify bot commented Nov 7, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Require two reviewer for test updates

This rule is failing.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@codecov
Copy link

codecov bot commented Nov 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants