feat: add rocm image build support and fix cuda#292
Merged
dolfim-ibm merged 10 commits intodocling-project:mainfrom Jul 31, 2025
Merged
feat: add rocm image build support and fix cuda#292dolfim-ibm merged 10 commits intodocling-project:mainfrom
dolfim-ibm merged 10 commits intodocling-project:mainfrom
Conversation
Signed-off-by: rmdg88 <rmdg88@gmail.com>
Signed-off-by: rmdg88 <rmdg88@gmail.com>
Contributor
|
✅ DCO Check Passed Thanks @rmdg88, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Signed-off-by: rmdg88 <rmdg88@gmail.com>
Signed-off-by: rmdg88 <rmdg88@gmail.com>
Signed-off-by: rmdg88 <rmdg88@gmail.com>
Signed-off-by: rmdg88 <rmdg88@gmail.com>
Signed-off-by: Rui-Dias-Gomes <rui.dias.gomes@ibm.com>
Signed-off-by: rmdg88 <rmdg88@gmail.com>
Signed-off-by: rmdg88 <rmdg88@gmail.com>
Signed-off-by: rmdg88 <rmdg88@gmail.com>
dolfim-ibm
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: begin sunsetting
docling-serve-cu124image buildremoved the
docling-serve-cu124from github workflow, left it in thepyproject.tomlandMakefile, so one can still explicitly build it locally if needed with:make docling-serve-cu124-imagechore: updated uv version and project deps with
uv lock --upgradefix: updated flash-attn wich resolves issues in NVIDIA CUDA images
resolves:
Cuda 12.8 image : ModuleNotFoundError: Could not import module 'RTDetrForObjectDetection' #242
No module named 'flash_attn_2_cuda' #269
docling-serve-cu128 fails to start: Missing flash_attn_2_cuda module #272
feat: added AMD ROCm build images support
partially resolves:
Add AMD ROCm and Intel accelerators #284
(i will create a new PR for the intel build later on)
docs: updated readme and deploy-examples for amd and nvidia