Skip to content

Remove deprecated methods from ParserResult and the SingleSelectExecutor class#12195

Open
mpdude wants to merge 1 commit intodoctrine:4.0.xfrom
mpdude:drop-deprecated-parser-result-methods
Open

Remove deprecated methods from ParserResult and the SingleSelectExecutor class#12195
mpdude wants to merge 1 commit intodoctrine:4.0.xfrom
mpdude:drop-deprecated-parser-result-methods

Conversation

@mpdude
Copy link
Contributor

@mpdude mpdude commented Oct 7, 2025 •
edited
Loading

This removes methods that have been deprecated in 2.20.x via #11188 and/or got deprecation notices added in #12196.

@mpdude mpdude force-pushed the drop-deprecated-parser-result-methods branch from 9a68fbf to e02d232 Compare October 7, 2025 14:32
@greg0ire greg0ire mentioned this pull request Oct 7, 2025
Closed
@mpdude mpdude mentioned this pull request Oct 7, 2025
Merged
greg0ire
greg0ire reviewed Oct 7, 2025
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add something in UPGRADE.md

@mpdude mpdude changed the title Remove deprecated methods from ParserResult Remove deprecated methods from ParserResult and the SingleSelectExecutor class Oct 7, 2025
@greg0ire
Copy link
Member

greg0ire commented Oct 7, 2025

The PHPStan baseline needs an update:

orm/phpstan-baseline.neon

Lines 2319 to 2323 in cdc52b2

-
message: '#^Parameter \#1 \$sql of method Doctrine\\DBAL\\Connection\:\:executeQuery\(\) expects string, list\<string\>\|string given\.$#'
identifier: argument.type
count: 1
path: src/Query/Exec/SingleSelectExecutor.php

@mpdude mpdude force-pushed the drop-deprecated-parser-result-methods branch from 41d021f to 1814d10 Compare October 7, 2025 21:25
greg0ire
greg0ire reviewed Oct 7, 2025
View reviewed changes
@mpdude mpdude force-pushed the drop-deprecated-parser-result-methods branch from 1814d10 to ac45a1c Compare October 8, 2025 08:04
@mpdude
Copy link
Contributor Author

mpdude commented Oct 8, 2025

fixed

@greg0ire
Copy link
Member

greg0ire commented Oct 8, 2025

Moar conflicts 😭

@mpdude mpdude force-pushed the drop-deprecated-parser-result-methods branch from ac45a1c to 8f95375 Compare October 8, 2025 20:57
@greg0ire
Copy link
Member

greg0ire commented Oct 8, 2025

Needs phpcbf :P

@mpdude mpdude force-pushed the drop-deprecated-parser-result-methods branch from 75c0189 to c5c66e5 Compare October 9, 2025 07:56
@greg0ire
Copy link
Member

greg0ire commented Oct 10, 2025

I think it is not important so support unserializing parser results from another major version release.

I'm not sure I agree… did you remove this test because it broke? If yes, there should be instructions in UPGRADE.md explaining what's needed to update from 3 to 4… clearing a cache, I guess.

@greg0ire greg0ire requested a review from derrabus October 10, 2025 19:09
@mpdude
Copy link
Contributor Author

mpdude commented Oct 11, 2025

IIRC yes – unserializing an old (2.x) ParserResult caused a notice, since it contained fields that now are no longer present in the class. I'll definetly add an upgrade notice.

@mpdude
Remove deprecated methods from ParserResult and the `SingleSelectEx…
713c985 
…ecutor` class

This removes methods that have been deprecated in 2.20.x via doctrine#11188 and/or got deprecation notices added in doctrine#12196.
@mpdude mpdude force-pushed the drop-deprecated-parser-result-methods branch from c5c66e5 to 713c985 Compare October 11, 2025 13:59
@mpdude
Copy link
Contributor Author

mpdude commented Oct 26, 2025

Should I do anything else here?

@greg0ire
Copy link
Member

greg0ire commented Oct 27, 2025

I'd like to get @derrabus 's opinion on this.

@greg0ire
Copy link
Member

greg0ire commented Oct 29, 2025

Also, this needs a rebase.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

@github-actions github-actions bot added the Stale label Jan 28, 2026
derrabus
derrabus approved these changes Jan 28, 2026
View reviewed changes
UPGRADE.md
Comment on lines +5 to +6
The internal structure of `Doctrine\ORM\Query\ParserResult` changed. Thus, it is no longer possible to unserialize cached parser result instances that
were created and serialized with the previous major version of the ORM.
Copy link
Member

@derrabus derrabus Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to create a compat layer?

@github-actions github-actions bot removed the Stale label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greg0ire greg0ire greg0ire left review comments

@derrabus derrabus derrabus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mpdude @greg0ire @derrabus