Skip to content

Conversation

@fulghum
Copy link
Contributor

@fulghum fulghum commented Dec 16, 2025

In Doltgres, SHOW TABLES was returning table names as well as other root object names, like sequence names. This PR changes the TablesOnSearchPath function to stop returning the other root object names.

Related to:
dolthub/doltgresql#1743

@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
6ed8d81 ok 5937471
version total_tests
6ed8d81 5937471
correctness_percentage
100.0

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fulghum fulghum merged commit e728b55 into main Dec 30, 2025
41 of 44 checks passed
@fulghum fulghum deleted the fulghum/bugfix branch December 30, 2025 00:50
@github-actions
Copy link

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 0.62
adds_updates_deletes 60000 60000 60000 3.19
deletes_only 0 60000 0 1.58
updates_only 0 0 60000 2.04

@github-actions
Copy link

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.05 2
batching batch sql 10000 1 0.07 2
batching by line sql 10000 1 0.07 1.86
blob 1 blob 200000 1 0.91 4.1 4.37
blob 2 blobs 200000 1 0.89 4.63 4.43
blob no blob 200000 1 0.9 2.79 2.7
col type datetime 200000 1 0.84 2.65 2.62
col type varchar 200000 1 0.67 3.84 3.84
config width 2 cols 200000 1 0.76 2.8 2.75
config width 32 cols 200000 1 1.98 3.02 2.56
config width 8 cols 200000 1 0.98 2.88 2.76
pk type float 200000 1 1.01 2.4 2.11
pk type int 200000 1 0.78 2.86 2.71
pk type varchar 200000 1 1.6 1.69 1.53
row count 1.6mm 1600000 1 5.83 2.98 2.9
row count 400k 400000 1 1.42 3.03 2.94
row count 800k 800000 1 2.94 2.93 2.86
secondary index four index 200000 1 3.52 1.39 1.2
secondary index no secondary 200000 1 0.87 2.87 2.84
secondary index one index 200000 1 1.11 2.66 2.47
secondary index two index 200000 1 2.03 1.81 1.72
sorting shuffled 1mm 1000000 0 5.16 2.92 2.8
sorting sorted 1mm 1000000 1 5.21 2.91 2.69

@github-actions
Copy link

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.25
dolt_blame_commit_filter system table 2.63
dolt_commit_ancestors_commit_filter system table 0.66
dolt_commits_commit_filter system table 1.1
dolt_diff_log_join_from_commit system table 2.87
dolt_diff_log_join_to_commit system table 2.84
dolt_diff_table_from_commit_filter system table 1.24
dolt_diff_table_to_commit_filter system table 1.19
dolt_diffs_commit_filter system table 1
dolt_history_commit_filter system table 1.48
dolt_log_commit_filter system table 1.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants