Skip to content

Conversation

@fulghum
Copy link
Contributor

@fulghum fulghum commented Nov 20, 2024

This change refactors the AuthServer implementation in GMS to the new AuthServer / AuthMethod structure from dolthub/vitess#379

This is preliminary work to set us up to add support for caching_sha2_password authentication.

Related to: dolthub/dolt#8496

Depends on: dolthub/vitess#379

@fulghum fulghum force-pushed the fulghum/auth-refactor branch 2 times, most recently from bed061f to 9faa7d6 Compare November 20, 2024 23:28
@fulghum fulghum force-pushed the fulghum/auth-refactor branch from 93d20e6 to 471af6d Compare November 21, 2024 22:17
@fulghum fulghum marked this pull request as ready for review November 22, 2024 00:27
Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fulghum fulghum merged commit 7b6a8c1 into main Nov 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants