Refactor: AuthServer

go.mod

@@ -6,7 +6,7 @@ require (
 	github.com/dolthub/go-icu-regex v0.0.0-20240916130659-0118adc6b662
 	github.com/dolthub/jsonpath v0.0.2-0.20240227200619-19675ab05c71
 	github.com/dolthub/sqllogictest/go v0.0.0-20201107003712-816f3ae12d81
-	github.com/dolthub/vitess v0.0.0-20241120000209-5ff664bddfc4
+	github.com/dolthub/vitess v0.0.0-20241121221517-3e7b5ffc22b0
 	github.com/go-kit/kit v0.10.0
 	github.com/go-sql-driver/mysql v1.7.2-0.20231213112541-0004702b931d
 	github.com/gocraft/dbr/v2 v2.7.2

go.sum

@@ -62,6 +62,8 @@ github.com/dolthub/vitess v0.0.0-20241119005402-6a198321d993 h1:MhD6jHjshx2djyUq
 github.com/dolthub/vitess v0.0.0-20241119005402-6a198321d993/go.mod h1:uBvlRluuL+SbEWTCZ68o0xvsdYZER3CEG/35INdzfJM=
 github.com/dolthub/vitess v0.0.0-20241120000209-5ff664bddfc4 h1:C3RSQjvv2T5TdQzRYpLLIbFxfyznzZi25XpOqdu89ng=
 github.com/dolthub/vitess v0.0.0-20241120000209-5ff664bddfc4/go.mod h1:uBvlRluuL+SbEWTCZ68o0xvsdYZER3CEG/35INdzfJM=
+github.com/dolthub/vitess v0.0.0-20241121221517-3e7b5ffc22b0 h1:C8X4RkkWKcrJG6rG+MsdFINX2PhB7ObpbBvFcWsI8K8=
+github.com/dolthub/vitess v0.0.0-20241121221517-3e7b5ffc22b0/go.mod h1:alcJgfdyIhFaAiYyEmuDCFSLCzedz3KCaIclLoCUtJg=
 github.com/dustin/go-humanize v0.0.0-20171111073723-bb3d318650d4/go.mod h1:HtrtbFcZ19U5GC7JDqmcUSB87Iq5E25KnS6fMYU6eOk=
 github.com/eapache/go-resiliency v1.1.0/go.mod h1:kFI+JgMyC7bLPUVY133qvEBtVayf5mFgVsvEsIPBvNs=
 github.com/eapache/go-xerial-snappy v0.0.0-20180814174437-776d5712da21/go.mod h1:+020luEh2TKB4/GOp8oxxtq0Daoen/Cii55CzbTV6DU=

sql/mysql_db/auth.go

@@ -0,0 +1,310 @@
+// Copyright 2024 Dolthub, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package mysql_db
+
+import (
+	"bytes"
+	"crypto/sha1"
+	"crypto/x509"
+	"encoding/hex"
+	"net"
+
+	"github.com/dolthub/vitess/go/mysql"
+	"github.com/sirupsen/logrus"
+
+	"github.com/dolthub/go-mysql-server/sql"
+)
+
+// authServer implements the mysql.AuthServer interface. It exposes configured AuthMethod implementations
+// that the auth framework in Vitess uses to negotiate authentication with a client. By default, authServer
+// configures support for the mysql_native_password auth plugin, as well as an extensible auth method, built
+// on the mysql_clear_password plugin, that integrators can use to provide extended authentication options,
+// through the use of registering PlaintextAuthPlugins with MySQLDb.
+type authServer struct {
+	authMethods []mysql.AuthMethod
+}
+
+var _ mysql.AuthServer = (*authServer)(nil)
+
+// newAuthServer creates a new instance of an authServer, configured with auth method implementations supporting
+// mysql_native_password support, as well as an extensible auth method, built on the mysql_clear_password auth
+// method, that allows integrators to extend authentication to allow additional schemes.
+func newAuthServer(db *MySQLDb) *authServer {
+	// The native password auth method allows auth over the mysql_native_password protocol
+	nativePasswordAuthMethod := mysql.NewMysqlNativeAuthMethod(
+		&nativePasswordHashStorage{db: db},
+		&nativePasswordUserValidator{db: db})
+
+	// TODO: Add CachingSha2Password AuthMethod
+
+	// The extended auth method allows for integrators to register their own PlaintextAuthPlugin implementations,
+	// and uses the MySQL clear auth method to send the auth information from the client to the server.
+	extendedAuthMethod := mysql.NewMysqlClearAuthMethod(
+		&extendedAuthPlainTextStorage{db: db},
+		&extendedAuthUserValidator{db: db})
+
+	return &authServer{
+		authMethods: []mysql.AuthMethod{nativePasswordAuthMethod, extendedAuthMethod},
+	}
+}
+
+// AuthMethods implements the mysql.AuthServer interface.
+func (as *authServer) AuthMethods() []mysql.AuthMethod {
+	return as.authMethods
+}
+
+// DefaultAuthMethodDescription implements the mysql.AuthServer interface.
+func (db *authServer) DefaultAuthMethodDescription() mysql.AuthMethodDescription {
+	return mysql.MysqlNativePassword
+}
+
+// extendedAuthPlainTextStorage implements the mysql.PlainTextStorage interface and plugs into
+// the MySQL clear password auth method in order to allow extension auth mechanisms to be used.
+// Integrators can register their own PlaintextAuthPlugin through the MySQLDb::SetPlugins method,
+// then if a user account's plugin is set to the registerd plugin, this PlainTextStorage, the
+// registered PlaintextAuthPlugin will be used to authenticate the user. This class serves as
+// a bridge between the MySQL clear password auth method implementation in Vitess, the user
+// account data stored in the MySQLDb, and custom PlaintextAuthPlugin implementations.
+type extendedAuthPlainTextStorage struct {
+	db *MySQLDb
+}
+
+var _ mysql.PlainTextStorage = (*extendedAuthPlainTextStorage)(nil)
+
+// UserEntryWithPassword implements the mysql.PlainTextStorage interface. This method is called by the
+// MySQL clear password auth method to authenticate a user with a custom PlaintextAuthPlugin that was
+// previously registered with the MySQLDb instance.
+func (f extendedAuthPlainTextStorage) UserEntryWithPassword(userCerts []*x509.Certificate, user string, password string, remoteAddr net.Addr) (mysql.Getter, error) {
+	db := f.db
+
+	host, err := extractHostAddress(remoteAddr)
+	if err != nil {
+		return nil, err
+	}
+
+	connUser := sql.MysqlConnectionUser{User: user, Host: host}
+	if !db.Enabled() {
+		return connUser, nil
+	}
+
+	rd := db.Reader()
+	defer rd.Close()
+
+	userEntry := db.GetUser(rd, user, host, false)
+	if userEntry == nil {
+		return nil, mysql.NewSQLError(mysql.ERAccessDeniedError, mysql.SSAccessDeniedError,
+			"Access denied for user '%v': no known user", user)
+	}
+
+	authPluginName := userEntry.Plugin
+	if authPluginName == "" {
+		return nil, mysql.NewSQLError(mysql.ERAccessDeniedError, mysql.SSAccessDeniedError,
+			"Access denied for user '%v': no auth plugin specified", user)
+	}
+
+	authplugin, ok := db.plugins[authPluginName]
+	if !ok {
+		return nil, mysql.NewSQLError(mysql.ERAccessDeniedError, mysql.SSAccessDeniedError,
+			"Access denied for user '%v'; auth plugin %s not registered with server", user, authPluginName)
+	}
+
+	authed, err := authplugin.Authenticate(db, user, userEntry, password)
+	if err != nil {
+		return nil, mysql.NewSQLError(mysql.ERAccessDeniedError, mysql.SSAccessDeniedError,
+			"Access denied for user '%v': %v", user, err)
+	}
+	if !authed {
+		return nil, mysql.NewSQLError(mysql.ERAccessDeniedError, mysql.SSAccessDeniedError,
+			"Access denied for user '%v'", user)
+	}
+	return connUser, nil
+}
+
+// extendedAuthUserValidator implements the mysql.UserValidator interface and plugs into the MySQL clear password
+// auth method.
+type extendedAuthUserValidator struct {
+	db *MySQLDb
+}
+
+var _ mysql.UserValidator = (*extendedAuthUserValidator)(nil)
+
+// HandleUser implements the mysql.UserValidator interface.
+func (uv extendedAuthUserValidator) HandleUser(user string, remoteAddr net.Addr) bool {
+	// If the mysql database is not enabled, then we don't have user information, so
+	// go ahead and return true without trying to look up the user in the db.
+	if !uv.db.Enabled() {
+		return true
+	}
+
+	host, err := extractHostAddress(remoteAddr)
+	if err != nil {
+		logrus.Warnf("error extracting host address: %v", err)
+		return false
+	}
+
+	db := uv.db
+	rd := db.Reader()
+	defer rd.Close()
+
+	if !db.Enabled() {
+		return true
+	}
+	userEntry := db.GetUser(rd, user, host, false)
+	if userEntry == nil {
+		return false
+	}
+
+	for pluginName, _ := range db.plugins {
+		if userEntry.Plugin == pluginName {
+			return true
+		}
+	}
+
+	return false
+}
+
+// nativePasswordHashStorage implements the mysql.HashStorage interface and plugs into the mysql_native_password
+// auth protocol. It is responsible for looking up a user in the MySQL database and validating a password hash
+// against the user's stored password hash.
+type nativePasswordHashStorage struct {
+	db *MySQLDb
+}
+
+var _ mysql.HashStorage = (*nativePasswordHashStorage)(nil)
+
+// UserEntryWithHash implements the mysql.HashStorage interface. This implementation is called by the MySQL
+// native password auth method to validate a password hash with the user's stored password hash.
+func (nphs *nativePasswordHashStorage) UserEntryWithHash(_ []*x509.Certificate, salt []byte, user string, authResponse []byte, remoteAddr net.Addr) (mysql.Getter, error) {
+	db := nphs.db
+
+	host, err := extractHostAddress(remoteAddr)
+	if err != nil {
+		return nil, err
+	}
+
+	rd := db.Reader()
+	defer rd.Close()
+
+	if !db.Enabled() {
+		return sql.MysqlConnectionUser{User: user, Host: host}, nil
+	}
+
+	userEntry := db.GetUser(rd, user, host, false)
+	if userEntry == nil || userEntry.Locked {
+		return nil, mysql.NewSQLError(mysql.ERAccessDeniedError, mysql.SSAccessDeniedError, "Access denied for user '%v'", user)
+	}
+	if len(userEntry.Password) > 0 {
+		if !validateMysqlNativePassword(authResponse, salt, userEntry.Password) {
+			return nil, mysql.NewSQLError(mysql.ERAccessDeniedError, mysql.SSAccessDeniedError, "Access denied for user '%v'", user)
+		}
+	} else if len(authResponse) > 0 {
+		// password is nil or empty, therefore no password is set
+		// a password was given and the account has no password set, therefore access is denied
+		return nil, mysql.NewSQLError(mysql.ERAccessDeniedError, mysql.SSAccessDeniedError, "Access denied for user '%v'", user)
+	}
+
+	return sql.MysqlConnectionUser{User: userEntry.User, Host: userEntry.Host}, nil
+}
+
+// nativePasswordUserValidator implements the mysql.UserValidator interface and plugs into the mysql_native_password
+// auth method in Vitess. This implementation is called by the native password auth method to determine if a specific
+// user and remote address can connect to this server via the mysql_native_password auth protocol.
+type nativePasswordUserValidator struct {
+	db *MySQLDb
+}
+
+var _ mysql.UserValidator = (*nativePasswordUserValidator)(nil)
+
+// HandleUser implements the mysql.UserValidator interface and verifies if the mysql_native_password auth method
+// can be used for the specified |user| at the specified |remoteAddr|.
+func (uv *nativePasswordUserValidator) HandleUser(user string, remoteAddr net.Addr) bool {
+	// If the mysql database is not enabled, then we don't have user information, so
+	// go ahead and return true without trying to look up the user in the db.
+	if !uv.db.Enabled() {
+		return true
+	}
+
+	host, err := extractHostAddress(remoteAddr)
+	if err != nil {
+		logrus.Warnf("error extracting host address: %v", err)
+		return false
+	}
+
+	db := uv.db
+	rd := db.Reader()
+	defer rd.Close()
+
+	if !db.Enabled() {
+		return true
+	}
+	userEntry := db.GetUser(rd, user, host, false)
+
+	return userEntry != nil && (userEntry.Plugin == "" || userEntry.Plugin == string(mysql.MysqlNativePassword))
+}
+
+// extractHostAddress extracts the host address from |addr|, checking to see if it is a unix socket, and if
+// so, returning "localhost" as the host.
+func extractHostAddress(addr net.Addr) (host string, err error) {
+	if addr.Network() == "unix" {
+		host = "localhost"
+	} else {
+		host, _, err = net.SplitHostPort(addr.String())
+		if err != nil {
+			if err.(*net.AddrError).Err == "missing port in address" {
+				host = addr.String()
+			} else {
+				return "", err
+			}
+		}
+	}
+	return host, nil
+}
+
+// validateMysqlNativePassword was taken from vitess and validates the password hash for the mysql_native_password
+// auth protocol. Note that this implementation has diverged slightly from the original code in Vitess.
+func validateMysqlNativePassword(authResponse, salt []byte, mysqlNativePassword string) bool {
+	// SERVER: recv(authResponse)
+	// 		   hash_stage1=xor(authResponse, sha1(salt,hash))
+	// 		   candidate_hash2=sha1(hash_stage1)
+	// 		   check(candidate_hash2==hash)
+	if len(authResponse) == 0 || len(mysqlNativePassword) == 0 {
+		return false
+	}
+	if mysqlNativePassword[0] == '*' {
+		mysqlNativePassword = mysqlNativePassword[1:]
+	}
+
+	hash, err := hex.DecodeString(mysqlNativePassword)
+	if err != nil {
+		return false
+	}
+
+	// scramble = SHA1(salt+hash)
+	crypt := sha1.New()
+	crypt.Write(salt)
+	crypt.Write(hash)
+	scramble := crypt.Sum(nil)
+
+	// token = scramble XOR stage1Hash
+	for i := range scramble {
+		scramble[i] ^= authResponse[i]
+	}
+	stage1Hash := scramble
+	crypt.Reset()
+	crypt.Write(stage1Hash)
+	candidateHash2 := crypt.Sum(nil)
+
+	return bytes.Equal(candidateHash2, hash)
+}