Skip to content

Conversation

@Hydrocharged
Copy link
Contributor

@Hydrocharged Hydrocharged commented Nov 23, 2024

This is a followup to the comments on this PR:

@Hydrocharged Hydrocharged changed the title Better error message for bad string for charset Better error message for invalid charset string Nov 23, 2024
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Hydrocharged Hydrocharged merged commit d5eeb13 into main Nov 23, 2024
8 checks passed
@Hydrocharged Hydrocharged deleted the daylon/better-error branch November 23, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants