[no-release-notes] generate query script plans #3120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jycor
force-pushed
the
james/script-plans
branch
from
d32306e to
2fa0640
Compare
nicktobey
approved these changes
Jul 25, 2025
enginetest/queries/script_queries.go
Outdated
| // ExpectedColumns indicates the Name and Type of the columns expected; no other schema fields are tested. | ||
| ExpectedColumns sql.Schema | ||
|
|
||
| // TODO: replace this with ExpectedPlan |
Contributor
There was a problem hiding this comment.
This shouldn't be replaced with ExpectedPlan. There's a lot of cases where you don't care about the exact plan, only that a certain index or join type gets used. Forcing the test to validate a specific plan makes the test much more brittle.
enginetest/queries/script_queries.go
Outdated
| // The string representation of indexes that we expect to appear in the query plan | ||
| ExpectedIndexes []string | ||
|
|
||
| // TODO: replace this with ExpectedPlan |
| fmt.Fprintf(&buf, `// Copyright 2024 Dolthub, Inc. | ||
| func writeHeader(buf *bytes.Buffer, pkg string) { | ||
| _, _ = fmt.Fprint(buf, "// Code generated by plangen.\n\n") | ||
| _, _ = fmt.Fprint(buf, `// Copyright 2024-2025 Dolthub, Inc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a way to write script plan tests and includes code to generate plans as well.
This allows us to write script tests that also enforce specific query plans.