include null values when evaluating anti joins created from WHERE NOT EXISTS
#3135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelamayxie
changed the title
IncludeNulls join types for anti joins created from WHERE NOT EXISTS
angelamayxie
changed the title
IncludeNulls join types for anti joins created from WHERE NOT EXISTSWHERE NOT EXISTS
fulghum
approved these changes
Aug 1, 2025
Contributor
fulghum
left a comment
fulghum
left a comment
There was a problem hiding this comment.
Nice work! I just had one question about one of the query plans that changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes dolthub/dolt#9615
We were not including null values when evaluating anti joins created from unnesting
WHERE NOT EXISTSstatements. This was causing us to return empty sets if there was a null value in the right side table of the anti join.