Skip to content

include null values when evaluating anti joins created from WHERE NOT EXISTS #3135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 1, 2025
Merged

include null values when evaluating anti joins created from WHERE NOT EXISTS #3135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
165e9b5
right column should not be skipped for nil comparisons in anti-joins
angelamayxie Jul 31, 2025
2acc3ba
Revert "right column should not be skipped for nil comparisons in ant…
angelamayxie Aug 1, 2025
c036970
make equals in antijoins from not exists null safe
angelamayxie Aug 1, 2025
f83e931
Revert "make equals in antijoins from not exists null safe"
angelamayxie Aug 1, 2025
6b61b7d
add join op test for where not exists
angelamayxie Aug 1, 2025
660c384
added AntiJoinIncludingNulls join type
angelamayxie Aug 1, 2025
966a51d
regenerate query plan tests
angelamayxie Aug 1, 2025
328e764
edit join type strings for consistency
angelamayxie Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions enginetest/join_op_tests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1921,6 +1921,18 @@ SELECT SUM(x) FROM xy WHERE x IN (
},
},
},
{
name: "where not exists",
setup: [][]string{
setup.XyData[0],
},
tests: []JoinOpTests{
{
Query: `select * from xy_hasnull x where not exists(select 1 from ab_hasnull a where a.b = x.y)`,
Expected: []sql.Row{{1, 0}, {3, nil}},
},
},
},
{
name: "multi-column merge join",
setup: [][]string{
Expand Down
46,544 changes: 22,664 additions & 23,880 deletions enginetest/queries/imdb_plans.go
View file
Open in desktop

Large diffs are not rendered by default.

30 changes: 15 additions & 15 deletions enginetest/queries/integration_plans.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions enginetest/queries/query_plans.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions enginetest/queries/tpch_plans.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion sql/analyzer/indexed_joins.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,11 @@ func convertAntiToLeftJoin(m *memo.Memo) error {
rightGrp := m.MemoizeProject(nil, anti.Right, projectExpressions)

// join is a new group
joinGrp := m.MemoizeLeftJoin(nil, anti.Left, rightGrp, plan.JoinTypeLeftOuterExcludeNulls, anti.Filter)
joinType := plan.JoinTypeLeftOuter
if anti.Op.IsExcludeNulls() {
joinType = plan.JoinTypeLeftOuterExcludeNulls
}
joinGrp := m.MemoizeLeftJoin(nil, anti.Left, rightGrp, joinType, anti.Filter)

// drop null projected columns on right table
nullFilters := make([]sql.Expression, len(nullify))
Expand Down
4 changes: 2 additions & 2 deletions sql/analyzer/unnest_exists_subqueries.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ func unnestExistSubqueries(ctx *sql.Context, scope *plan.Scope, a *Analyzer, fil
switch joinType {
case plan.JoinTypeAnti:
cond := expression.NewLiteral(true, types.Boolean)
ret = plan.NewAntiJoin(ret, s.inner, cond).WithComment(comment)
ret = plan.NewAntiJoinIncludingNulls(ret, s.inner, cond).WithComment(comment)
qFlags.Set(sql.QFlagInnerJoin)
case plan.JoinTypeSemi:
ret = plan.NewCrossJoin(ret, s.inner).WithComment(comment)
Expand All @@ -209,7 +209,7 @@ func unnestExistSubqueries(ctx *sql.Context, scope *plan.Scope, a *Analyzer, fil

switch joinType {
case plan.JoinTypeAnti:
ret = plan.NewAntiJoin(ret, s.inner, expression.JoinAnd(outerFilters...)).WithComment(comment)
ret = plan.NewAntiJoinIncludingNulls(ret, s.inner, expression.JoinAnd(outerFilters...)).WithComment(comment)
qFlags.Set(sql.QFlagInnerJoin)
case plan.JoinTypeSemi:
ret = plan.NewSemiJoin(ret, s.inner, expression.JoinAnd(outerFilters...)).WithComment(comment)
Expand Down
4 changes: 2 additions & 2 deletions sql/memo/join_order_builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,7 @@ func (j *joinOrderBuilder) constructJoin(
rel = &LeftJoin{b}
case plan.JoinTypeSemi:
rel = &SemiJoin{b}
case plan.JoinTypeAnti:
case plan.JoinTypeAnti, plan.JoinTypeAntiIncludeNulls:
rel = &AntiJoin{b}
case plan.JoinTypeLateralInner, plan.JoinTypeLateralCross,
plan.JoinTypeLateralRight, plan.JoinTypeLateralLeft:
Expand Down Expand Up @@ -1428,7 +1428,7 @@ func getOpIdx(e *edge) int {
return 1
case plan.JoinTypeSemi:
return 2
case plan.JoinTypeAnti:
case plan.JoinTypeAnti, plan.JoinTypeAntiIncludeNulls:
return 3
case plan.JoinTypeLeftOuter:
return 4
Expand Down
Loading
Loading