Skip to content

Conversation

@elianddb
Copy link
Contributor

@elianddb elianddb commented Aug 7, 2025

Fixes dolthub/dolt#9641
Fixed Max1Row optimization being incorrectly applied to UNION subqueries. Also fixed UNION schema type reconciliation using GeneralizeTypes().

@elianddb elianddb force-pushed the elianddb/9641-union-bit-field-overflow branch 2 times, most recently from 93f1fde to 3fe9336 Compare August 8, 2025 20:37
@elianddb elianddb changed the title dolthub/dolt#9641 - Include BIT types in IsUnsigned function dolthub/dolt#9641 - Include BIT Overflow Aug 8, 2025
@elianddb elianddb changed the title dolthub/dolt#9641 - Include BIT Overflow dolthub/dolt#9641 - Fix BIT Overflow Aug 8, 2025
@elianddb elianddb requested a review from jycor August 12, 2025 16:33
@elianddb elianddb force-pushed the elianddb/9641-union-bit-field-overflow branch from b2556a7 to db0f0db Compare August 13, 2025 17:15
@elianddb elianddb force-pushed the elianddb/9641-union-bit-field-overflow branch from 92e8581 to ba16e56 Compare August 13, 2025 19:25
@elianddb elianddb force-pushed the elianddb/9641-union-bit-field-overflow branch from 8ee9cf1 to 47dc55b Compare August 15, 2025 23:35
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elianddb elianddb merged commit 30de574 into main Aug 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

48 is beyond the maximum value that can be held by 1 bits

3 participants