Conversation
…ed, which is called immediately after the connection is authenticated. This allows a server implementation to know the authenticated user without waiting for the first command interactions, such as ComQuery or ComInitDB.
zachmu
approved these changes
Nov 24, 2025
go/sqltypes/arithmetic_test.go
Outdated
| // type cannot represent the value the conversion succeeds but the result value is implementation-dependent. | ||
| // | ||
| // And indeed, the test fails on arm64 but passes on amd64 because the computed conversion is different. | ||
| tcases[6].skip = true |
Member
There was a problem hiding this comment.
Can we compute this boolean above and assign it to the test struct literal in its initializer instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a server implementation to know the authenticated user without waiting for the first command interactions, such as ComQuery or ComInitDB.