Error message details

[xterao]

Add case-specific error messages for exceptional scenarios during field-access element parsing. Errors are now reported for:

• The source of a for directive element isn’t an Iterable type.
• A static-property call whose first property isn’t declared both static and public.
• DAO-parameter usage validation when a parameter name duplicates a for directive element name and isn’t used.
• the top of the field access element is of a type that cannot be converted to PsiClassType

Additionally, refactor the SQL inspection Visitor by extracting each processing task into separate Processor classes.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull Request Overview

This PR introduces case-specific error messages during field-access element parsing and refactors the SQL inspection visitor code by extracting distinct processing tasks into dedicated processor classes. Key changes include:

• Enhanced error messages and validations in both SQL and Java/Kotlin inspection components.
• Extraction of processor classes (e.g. InspectionStaticFieldAccessVisitorProcessor, InspectionPrimaryVisitorProcessor, etc.) to modularize SQL processing tasks.
• Updates to test data and message bundles to support the new error cases.

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
duplicateForDirectiveDefinitionNames.sql	Added test SQL with duplicate for directive definitions to trigger the new error reporting.
DaoMethodVariableInspectionTestDao.java	Updated method signatures and inline error markers to reflect duplicate parameter scenarios.
DomaUseVariableTest.kt	Updated test to include the new duplicate for directive definition SQL.
DomaToolsBundle_ja.properties & DomaToolsBundle.properties	Added and modified error message keys for specific SQL inspection error cases.
SqlElIdExprReference.kt, SqlVisitorBase.kt, SqlInspectionVisitor.kt	Adjusted references and integrated new processor classes for error validations.
Inspection Visitor Processors (several files)	Introduced dedicated processor classes for static field access, primary expressions, for directive, and field access validations.
DaoMethodVariableInspector.kt	Updated logic to differentiate between duplicate for directive definitions and unused SQL parameters.
DocumentDaoParameterGenerator.kt, SqlParameterCompletionProvider.kt	Minor adjustments to ensure proper type handling in for directive processing.
ForDirectiveUtil.kt & Validation Results	Modified utility functions to incorporate DAO method context for determining class types and error highlight results.

Comments suppressed due to low confidence (1)

src/main/kotlin/org/domaframework/doma/intellij/common/util/ForDirectiveUtil.kt:382

• The function 'getTopForDirectiveDeclarationClassType' is expected to return a PsiParentClass or null, but this branch returns a ValidationNotFoundTopTypeResult, which may violate the method's type contract. Consider returning null or refactoring to ensure consistent return types that match PsiParentClass?

val classType = parentType as? PsiClassType ?: return ValidationNotFoundTopTypeResult(blocks.first(), shortName)