-
Notifications
You must be signed in to change notification settings - Fork 296
feat: add error event propagation to downstream nodes #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
guptapratykshh
wants to merge
29
commits into
dora-rs:main
Choose a base branch
from
guptapratykshh:feature/error-event-propagation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 17 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
454cea3
feat: add error event propagation to downstream nodes
guptapratykshh 359bca6
fix: treat nodes killed by grace duration as successful stops
guptapratykshh 7d7aad7
fix: gracefully handle connection errors during daemon shutdown
guptapratykshh 49707c0
fixed the formatting
guptapratykshh fb05aa4
Fixed CLI command failures (dora stop/destroy) that were occurring
guptapratykshh 21d8546
feature/error-event-propagation
guptapratykshh 321590c
refactor: replace explicit send_error API with automatic error propag…
guptapratykshh 52e6be1
fixed the formatting issues
guptapratykshh a4f8435
refactor: rename InputError to NodeFailed and support multiple affect…
guptapratykshh e61e585
refactor: rename InputError to NodeFailed and support multiple affect…
guptapratykshh 5440b99
refactor: rename InputError to NodeFailed and support multiple affect…
guptapratykshh e97523e
fix: address mentor feedback on error propagation PR
guptapratykshh c1b0445
fix: apply cargo fmt formatting fixes
guptapratykshh 615788b
Bump dora-message version to 0.7.0-alpha
phil-opp 295d048
Refactor error propagation to send single NodeFailed message, receive…
guptapratykshh 51dfa4e
Merge remote-tracking branch 'upstream/main' into feature/error-event…
guptapratykshh 2f0979a
Add NodeFailed pattern match to topic info command
guptapratykshh 170c69c
fix: address reviewer feedback on error propagation PR (#1252)
guptapratykshh afa9c14
Merge branch 'main' into feature/error-event-propagation
guptapratykshh 2435f00
Merge branch 'main' into feature/error-event-propagation
phil-opp 3f5a188
Bump dora-message version to 0.8.0-alpha
phil-opp 22d4536
Undo unrelated change (and use `wrap_err_with` instead)
phil-opp fd32593
Undo more unrelated changes
phil-opp ba55ab5
Fix: Make new example crates part of workspace
phil-opp bdbbfa7
Add build keys to dataflow and use correct paths
phil-opp fc3d61d
Improve println outputs in examples
phil-opp fb78c72
Fix build instruction in README and remove unneccesary/incorrect sect…
phil-opp f2350b1
Run new error event example on CI
phil-opp 669256b
Add `rust-version` field to new example
phil-opp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.