Skip to content

feat(cli): implement 'dora node info' command (#1203) #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
guptapratykshh wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(cli): implement 'dora node info' command (#1203) #1267

guptapratykshh wants to merge 4 commits into from

Conversation

@guptapratykshh
Copy link
Contributor

@guptapratykshh guptapratykshh commented Dec 17, 2025 •
edited by phil-opp
Loading

This PR introduces new dora node info command that offers detailed information about running nodes in dataflows. This makes it easier to monitor node status, connections, and resource usage.

The new command provides a clear view of any node in dataflow:

  • Status & Process Info: Shows the node's running status and process ID (PID).
  • Dataflow Context: Displays which dataflow the node belongs to, along with the daemon or machine it's running on.
  • Topology: Lists all input topics that the node subscribes to and the output topics it publishes.
  • Resource Metrics: Shows real-time CPU usage, memory consumption, and disk I/O statistics.

Resolves #1203

@guptapratykshh guptapratykshh force-pushed the feature/node-info-command-1203 branch from 6e4925c to 9874c2b Compare December 17, 2025 19:58
@guptapratykshh
Copy link
Contributor Author

guptapratykshh commented Dec 27, 2025

Please review this PR. Thanks. @phil-opp

@haixuanTao
Copy link
Collaborator

haixuanTao commented Dec 30, 2025

Closing this as well because there is no way you can get cpu_usage from the daemon as it is currently implemented.

@haixuanTao haixuanTao closed this Dec 30, 2025
@guptapratykshh
Copy link
Contributor Author

guptapratykshh commented Jan 10, 2026

I double-checked daemon/src/lib.rs and it looks like we're actually already grabbing CPU stats via sysinfo in
collect_and_send_metrics. The daemon refreshes this every few seconds and pushes it to the coordinator, so the data is there and ready to be displayed.

@phil-opp
Copy link
Collaborator

phil-opp commented Jan 14, 2026

Yes, this was added as part of #1251

@phil-opp phil-opp reopened this Jan 14, 2026
@haixuanTao
Copy link
Collaborator

haixuanTao commented Jan 14, 2026

Ok my bad, didn't look at @1251

@guptapratykshh
Copy link
Contributor Author

guptapratykshh commented Jan 26, 2026

any updates on this @phil-opp

phil-opp
phil-opp reviewed Jan 26, 2026
View reviewed changes
binaries/cli/src/command/mod.rs
Copy link
Collaborator

@phil-opp phil-opp Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove the unrelated edits in this file?

binaries/cli/src/command/node/info.rs Outdated
pub struct Info {
/// Name of the node to inspect
#[clap(value_name = "NODE_NAME")]
node_name: NodeId,
Copy link
Collaborator

@phil-opp phil-opp Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're typically talking about node IDs, not names in Dora.

binaries/cli/src/command/node/info.rs Outdated
match format {
OutputFormat::Table => {
println!("Name: {}", selected_node.node_id);
println!("Status: Running");
Copy link
Collaborator

@phil-opp phil-opp Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why hardcode this? The node might not be running anymore.

@guptapratykshh guptapratykshh force-pushed the feature/node-info-command-1203 branch from 4f77f95 to 18aed9b Compare January 26, 2026 16:17
@guptapratykshh guptapratykshh force-pushed the feature/node-info-command-1203 branch from 18aed9b to 042c12e Compare January 26, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-opp phil-opp Awaiting requested review from phil-opp

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement dora node info Command

3 participants

@guptapratykshh @haixuanTao @phil-opp