Skip to content

Conversation

@chrislearn
Copy link
Contributor

This PR primarily addresses warnings encountered during cargo build and cargo clippy.

Some basic documentation comments have been added, and some code has been optimized.

opentelemetry_jaeger::new_agent_pipeline appears to be deprecated; it was not modified in this PR but will be fixed in a future PR.

@haixuanTao
Copy link
Collaborator

Could we try to avoid empty commit messages?

@haixuanTao
Copy link
Collaborator

Some of those change is probably conflict with a bigger PR at #1259

@chrislearn chrislearn marked this pull request as draft December 29, 2025 14:17
@chrislearn
Copy link
Contributor Author

Some of those change is probably conflict with a bigger PR at #1259

OK, I set this PR as draft until #1259 merged.

@haixuanTao
Copy link
Collaborator

Could we try instead of manually pushing for cargo clippy warning fix use an automated way of fixing clippy warning like https://github.com/MarcoIeni/cargo-assist otherwise we can also try to use something like claude that should detect clippy warning on main and propose a fix without touching at the logic @chrislearn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants